fix: trigger docs deploy via workflow_call from docs.yml#443
Merged
Conversation
28dc896 to
cca22ea
Compare
cca22ea to
4a3435d
Compare
4a3435d to
a445d81
Compare
workflow_run does not fire for tag-triggered workflows, and GITHUB_TOKEN pushes do not trigger other workflows. Use workflow_call instead: docs.yml explicitly calls docs-deploy.yml after publish jobs complete. The deploy job only runs when at least one publish job succeeded, so PR builds (where all publish jobs are skipped) do not trigger a deploy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
a445d81 to
48a9ecb
Compare
viviveevee
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two issues prevented
docs-deploy.ymlfrom triggering afterdocs.ymlpushed todocs-deployment:GITHUB_TOKENpushes don't trigger other workflows — by design, to prevent infinite loopsworkflow_rundoesn't fire for tag-triggered workflows — so versioned doc deploys fromv*tags would never deploy to the ICFix
Use
workflow_call—docs.ymlexplicitly callsdocs-deploy.ymlas a job after the publish jobs complete.The
deploy-to-icjob is skipped on PR builds viaif: github.event_name != 'pull_request'.Trigger matrix
maindocs/v*or tagv*